Skip to content

USSN treatment in M&M; extend ScaleMassLossWithSurfaceHeliumAbundance beyond CHE #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ilyamandel merged 10 commits into from
Oct 26, 2025
Merged

USSN treatment in M&M; extend ScaleMassLossWithSurfaceHeliumAbundance beyond CHE #1437

ilyamandel merged 10 commits into from
Oct 26, 2025

Conversation

@ilyamandel
Copy link
Collaborator

@ilyamandel ilyamandel commented Oct 26, 2025 •
edited
Loading

  • Added option --USSN-kicks-override-mandel-muller ; if set to true, use user-defined USSN kicks (as a fixed value) in lieu of the Mandel & Muller kick prescription for USSNe
  • Replaced --scale-CHE-mass-loss-with-surface-helium-abundance with the more general --scale-mass-loss-with-surface-helium-abundance (applies to all MS stars, not just CHE stars)
  • Updated rotational velocity solver to use boost root finder

@ilyamandel ilyamandel requested a review from jeffriley October 26, 2025 17:26
@ilyamandel ilyamandel marked this pull request as draft October 26, 2025 17:26
@github-actions
Copy link

github-actions bot commented Oct 26, 2025

✅ COMPAS Build Successful!

Item Value
Commit 0160911
Logs View workflow

Detailed Evolution Plot

Click to view evolution plot

Generated by COMPAS CI

@github-actions
Copy link

github-actions bot commented Oct 26, 2025

✅ COMPAS Build Successful!

Item Value
Commit b2bd0f3
Logs View workflow

Detailed Evolution Plot

Click to view evolution plot

Generated by COMPAS CI

@github-actions
Copy link

github-actions bot commented Oct 26, 2025

✅ COMPAS Build Successful!

Item Value
Commit 0130fbd
Logs View workflow

Detailed Evolution Plot

Click to view evolution plot

Generated by COMPAS CI

@ilyamandel ilyamandel marked this pull request as ready for review October 26, 2025 22:58
@github-actions
Copy link

github-actions bot commented Oct 26, 2025

✅ COMPAS Build Successful!

Item Value
Commit a4a791f
Logs View workflow

Detailed Evolution Plot

Click to view evolution plot

Generated by COMPAS CI

jeffriley
jeffriley approved these changes Oct 26, 2025
View reviewed changes
Copy link
Collaborator

@jeffriley jeffriley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good @ilyamandel . I made two small fixes - I'll leave it to you to merge.

When I started reviewing my first suggestion was going to be changing "overwrite" to "override", but as if by magic, that was done :-)

@ilyamandel ilyamandel merged commit fdff67f into dev Oct 26, 2025
3 checks passed
@ilyamandel ilyamandel deleted the USSN branch October 26, 2025 23:40
@github-actions
Copy link

github-actions bot commented Oct 26, 2025

✅ COMPAS Build Successful!

Item Value
Commit b489ec6
Logs View workflow

Detailed Evolution Plot

Click to view evolution plot

Generated by COMPAS CI

@brcekadam brcekadam mentioned this pull request Dec 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffriley jeffriley jeffriley approved these changes

@SimonStevenson SimonStevenson Awaiting requested review from SimonStevenson

@brcekadam brcekadam Awaiting requested review from brcekadam

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ilyamandel @jeffriley